[PATCH] D47208: [profile] Support profiling runtime on Fuchsia

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformFuchsia.c:31
+  void *Buffer;
+};
+
----------------
This needs more documentation.


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformFuchsia.c:70
+
+static void initVMOWriter(ProfDataWriter *BufferWriter,
+                          struct WriterContext *Ctx) {
----------------
BufferWriter --> This  to make the naming consistent.


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformFuchsia.c:147
+void __llvm_profile_initialize_file(void) {
+  /* Unsupported */
+}
----------------
Perhaps emit a PROF_ERR here.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D47208