[PATCH] D46653: Start support for linking object files with split stacks

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added inline comments.


================
Comment at: ELF/InputSection.cpp:841
+  // Sort both collections to compare addresses efficiently.
+  std::sort(MorestackCalls.begin(), MorestackCalls.end(),
+            [](const Relocation *LHS, const Relocation *RHS) {
----------------
Please use llvm::sort instead of std::sort. See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements.


================
Comment at: ELF/InputSection.cpp:847
+                                  AdjustedPrologues.end());
+  std::sort(Adjusted.begin(), Adjusted.end(),
+            [](const Defined *LHS, const Defined *RHS) {
----------------
Same here. 


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46653