[PATCH] D47560: [CMake] Use find_package to find zlib

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/cmake/config-ix.cmake:112
+      include_directories(${ZLIB_INCLUDE_DIR})
+    endif()
   endif()
----------------
delcypher wrote:
> If `LLVM_ENABLE_ZLIB` but `ZLIB_FOUND` is `FALSE` we should emit an error telling the user that Zlib couldn't be found and that should either tell CMake how to find it or set `LLVM_ENABLE_ZLIB` to `FALSE`. You also use the `REQUIRED` argument to `find_package()` as an alternative.
I'm fine doing that, but it'd would be a different behavior from the current one where we silently ignore the missing library?


Repository:
  rL LLVM

https://reviews.llvm.org/D47560