[PATCH] D47560: [CMake] Use find_package to find zlib

[Dan Liew via Phabricator via llvm-commits]

delcypher added inline comments.


================
Comment at: llvm/cmake/config-ix.cmake:113
+    endif()
   endif()
 
----------------
delcypher wrote:
> We need to handle the case that Zlib was found previously but `LLVM_ENABLE_ZLIB` is now `FALSE`. You can either do it here so that `HAVE_LIBZ` is set to `FALSE` or you can update all uses of `HAVE_LIBZ` to also check if `LLVM_ENABLE_ZLIB` is set to `TRUE`.
Oh wait. `HAVE_LIBZ` is a regular variable and not  a cache variable. Sorry I was confusing it with `ZLIB_FOUND`. In that case I think your implementation should work fine in the scenario I mentioned.


Repository:
  rL LLVM

https://reviews.llvm.org/D47560