[PATCH] D46298: AMDGPU: Remove deadcode in isSDNodeSourceOfDivergence()

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 30 16:01:40 PDT 2018


tstellar added a comment.

In https://reviews.llvm.org/D46298#1110789, @arsenm wrote:

> In https://reviews.llvm.org/D46298#1110788, @alex-t wrote:
>
> > > I agree isVGPR should be illegal to call for R600
> >
> > So, how would you handle the bunch of r600 tests then?
> >  We could claim the support of DA related stuff for GCN only but it should be explicitly agreed and documented somehow.
>
>
> Disable this for r600. It doesn't have the SGPR/VGPR split issue we want this for, so it doesn't really matter


My patch does this, but just for ISD:Register and ISD::CopyFromRegister, should I just disable this analysis completely for r600?


Repository:
  rL LLVM

https://reviews.llvm.org/D46298





More information about the llvm-commits mailing list