[PATCH] D47210: [lit] Fix the `--max-time` flag feature which was completely broken.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

+ at thakis, who has been prototyping some lit optimizations, I think.

> Another approach is to depend on the pustil module again and have it walk through all child processes of lit and kill them. This is the simplest short term solution. This probably the right thing to do because --max-time doesn't seem that widely used. Otherwise someone would have already tried to fix --max-time before me.

That sounds like a good way to go.

The multiprocessing shutdown behavior leads a lot to be desired, and it's basically impossible to write reliable tests for it. I regularly have problems interrupting lit test execution here on Windows. It worked better when I used mintty, but I switched back to cmd after updating to Windows 10. I think improving all that behavior is a separate issue that's out of scope for this, and probably a higher priority.


https://reviews.llvm.org/D47210