[PATCH] D47540: [lld] Enable Visual Studio compatible output

[Chris Jackson via Phabricator via llvm-commits]

chrisjackson added inline comments.


================
Comment at: ELF/Relocations.cpp:638
       Config->NoinhibitExec) {
-    warn(Msg);
+    warn(Msg, Src);
     return false;
----------------
ruiu wrote:
> You include `Src` in an error message and also pass `Src` to the function. As a result, I believe the same string is printed out more than once. That would look pretty odd.
Src remains inside Msg so that the output diagnostic message text remains unchanged if --vs-diagnostics is not enabled. It is is also passed as a separate parameter so that it can be used as the origin component of the message when --vs-disagnostics is enabled. This enables the source hyperlink functionality in the VS error list.


https://reviews.llvm.org/D47540