[PATCH] D47523: [X86] Extract latency of fldz/fld1 in separate classes.
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 30 08:35:17 PDT 2018
courbet added a comment.
Thanks
================
Comment at: lib/Target/X86/X86Schedule.td:146
+def WriteF80Constant0 : SchedWrite;
+def WriteF80Constant1 : SchedWrite;
def WriteFLoadX : SchedWrite;
----------------
RKSimon wrote:
> Shorten the names to WriteFLD0, WriteFLD1, - allows you to remove all the indentation changes.
>
> Please add WriteFLDC for the other math constants (FLDPI etc.)
> Shorten the names to WriteFLD0, WriteFLD1, - allows you to remove all the indentation changes.
Done.
> Please add WriteFLDC for the other math constants (FLDPI etc.)
If you don't mind I'll tacle this one in a separate diff.
================
Comment at: lib/Target/X86/X86ScheduleZnver1.td:818
-// FLDZ.
-def : InstRW<[ZnWriteFPU13], (instregex "LD_F0")>;
-
----------------
RKSimon wrote:
> Just replace these with SchedAlias instead of entries above - that's what is mainly used in znver1
I'm not sure what you mean.
Getting rid of the definition for ZnWriteFPU3 and alias it to WriteFLD0 ?
Repository:
rL LLVM
https://reviews.llvm.org/D47523
More information about the llvm-commits
mailing list