[PATCH] D47505: [llvm-strip] Add -o option

Paul Semel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 30 03:56:13 PDT 2018


paulsemel added inline comments.


================
Comment at: tools/llvm-objcopy/StripOpts.td:11-12
+defm output : Eq<"o">,
+              MetaVarName<"output">,
+              HelpText<"Output file">;
+
----------------
jhenderson wrote:
> paulsemel wrote:
> > what about :
> > ```
> >  MetaVarName<"file">,
> >  HelpText<"Output stripped file into <file>">;
> > ```
> I think we should avoid mentioning "stripped" in the help text, because it's possible even now to use switches to prevent any actual stripping from occurring.
Fair enough, but I think this might still be changed to be more verbose :)


Repository:
  rL LLVM

https://reviews.llvm.org/D47505





More information about the llvm-commits mailing list