[PATCH] D47505: [llvm-strip] Add -o option

[Paul Semel via Phabricator via llvm-commits]

paulsemel added a comment.

Just two nits for me



================
Comment at: tools/llvm-objcopy/StripOpts.td:11-12
+defm output : Eq<"o">,
+              MetaVarName<"output">,
+              HelpText<"Output file">;
+
----------------
what about :
```
 MetaVarName<"file">,
 HelpText<"Output stripped file into <file>">;
```


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:581-583
+  Config.OutputFilename = InputArgs.hasArg(STRIP_output)
+                              ? InputArgs.getLastArg(STRIP_output)->getValue()
+                              : Positional[0];
----------------
I think it should be :
```
Config.OutputFilename = InputArgs.getLastArgValue(STRIP_output, Positional[0]);
```


Repository:
  rL LLVM

https://reviews.llvm.org/D47505