[PATCH] D46118: [RISCV] AsmParser support for the li pseudo instruction

[Mario Werner via Phabricator via llvm-commits]

niosHD added inline comments.


================
Comment at: lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1188
+
+  switch (Inst.getOpcode()) {
+  case RISCV::PseudoLI: {
----------------
sabuasal wrote:
> Nit: why is this a switch, are you expecting to be handling more Pseudo instructions?
Yes, I expected that other pseudo instructions that expand to multiple instructions (e.g., `la`, symbol versions of  `lb`, `sb`, ...)  will be expanded here in the future too.  Anyway, since we currently do not have the code and given that it is a small change anyway, I will go with the `if` instead.

Thank you for the comment!


https://reviews.llvm.org/D46118