[PATCH] D47511: [AMDGPU] Construct memory clauses before RA

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 29 20:54:06 PDT 2018


mgrang added inline comments.


================
Comment at: lib/Target/AMDGPU/SIFormMemoryClauses.cpp:171
+
+  std::sort(CoveringSubregs.begin(), CoveringSubregs.end(),
+            [this](unsigned A, unsigned B) {
----------------
Please use llvm::sort instead of std::sort. See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements.


https://reviews.llvm.org/D47511





More information about the llvm-commits mailing list