[PATCH] D47500: [WebAssembly] Add support for response file parsing
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 29 20:42:02 PDT 2018
ruiu added inline comments.
================
Comment at: wasm/Driver.cpp:145
unsigned MissingCount;
opt::InputArgList Args = this->ParseArgs(Vec, MissingIndex, MissingCount);
----------------
sbc100 wrote:
> ruiu wrote:
> > I think you should add ExpandResponseFiles before this line.
> ParseArgs is called twice, once before and once after. This is the how COFF and ELF do it too.
But you don't need to cargo-cult that, no?
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D47500
More information about the llvm-commits
mailing list