[PATCH] D44090: [WebAssembly] Support instruction selection for catching exceptions
Derek Schuff via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 29 16:46:50 PDT 2018
dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.
Otherwise LGTM
================
Comment at: lib/Target/WebAssembly/WebAssemblyRegisterInfo.h:48
unsigned Kind = 0) const override;
+ const uint32_t *getNoPreservedMask() const override { return nullptr; }
};
----------------
aheejin wrote:
> This was needed to prevent assertions from [[ https://github.com/llvm-mirror/llvm/blob/5365e8b41893d044805a280c862c6a9a8732f3cc/lib/CodeGen/MachineBasicBlock.cpp#L1426-L1438 | these functions ]].
There should be a comment about that here, since the mask is something that shouldn't apply to wasm.
Repository:
rL LLVM
https://reviews.llvm.org/D44090
More information about the llvm-commits
mailing list