[PATCH] D47162: [WebAssembly] Initial support for LTO

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Generally looking good, but I'd like to wait for pcc as he knows more than me about LTO.



================
Comment at: wasm/InputFiles.cpp:407
+  if (T.getArch() != Triple::wasm32) {
+    error(toString(MB.getBufferIdentifier()) + ": machine type must be wasm32");
+    return;
----------------
I think you can use `toString(this)` instead of `toString(MB...)`.


================
Comment at: wasm/LTO.h:51
+  std::unique_ptr<llvm::lto::LTO> LTOObj;
+  std::vector<SmallString<0>> Buff;
+  std::vector<std::unique_ptr<MemoryBuffer>> Files;
----------------
nit: Buff -> Buf for consistency.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47162