[PATCH] D44598: [lit] Report line number for failed RUN command

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In https://reviews.llvm.org/D44598#1115251, @jdenny wrote:

> In https://reviews.llvm.org/D44598#1115242, @delcypher wrote:
>
> > A high level question. Why are we even testing using `cmd.exe` with an external shell? IIRC that's not a use case LLVM uses for Windows. Instead
> >  the internal shell is used on Windows. Is this (`cmd.exe` as an external shell) really something we want to support? I don't see anything desirable about supporting `cmd.exe` as an
> >  external shell because that means it can be very easy to write non-portable shell tests.
>
>
> I'm not a windows developer.  I fixed that because others reverted my patch when it broke windows buildbots.  Someone else will have to answer.  Here's the bugzilla, in case that helps:
>
> https://bugs.llvm.org/show_bug.cgi?id=37239


Hmm.  I'm now remembering that this patch broke only lit's own tests -- both in that bugzilla and when I eventually built it in windows myself.  That supports your assessment.  Then again, I didn't attempt to build all the LLVM test suites in windows.

I'll post the question in that bugzilla in case they're not following here.


Repository:
  rL LLVM

https://reviews.llvm.org/D44598