[PATCH] D47391: [COFF] Simplify symbol table output section computation

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 29 13:52:37 PDT 2018


smeenai added inline comments.


================
Comment at: COFF/Writer.cpp:638
 
   switch (Def->kind()) {
   case Symbol::DefinedAbsoluteKind:
----------------
pcc wrote:
> Can we move this switch to the top of the function? Then the only code that needs to care about output sections will be in the default case of the switch.
Good idea; I'll throw up a patch in a bit.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47391





More information about the llvm-commits mailing list