[PATCH] D47098: [ELF] Make R_GOTONLY_PC_FROM_END R_GOTREL_FROM_END relative to _GLOBAL_OFFSET_TABLE_ instead of end of .got

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked 3 inline comments as done.
MaskRay added inline comments.


================
Comment at: test/ELF/relocation-i686.s:3
 // RUN: llvm-mc -filetype=obj -triple=i686-unknown-linux %p/Inputs/shared.s -o %t2.o
-// RUN: ld.lld -shared %t2.o -o %t2.so
+// RUN: ld.lld -shared %t2.o -soname t2.so -o %t2.so
 // RUN: ld.lld --hash-style=sysv %t %t2.so -o %t2
----------------
grimar wrote:
> MaskRay wrote:
> > grimar wrote:
> > > Why you had to do that?
> > In case the pathname of %t2.o is too long in some environment and makes `DT_NEEDED` of `%t2` longer and changes addresses of other fields.
> This sounds like an independent change for me.
Do you mean I should commit this change (-soname t2.so) in a different revision?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47098