[PATCH] D47339: [GVN,NewGVN] Propagate nonnull if K dominates J.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 29 06:51:54 PDT 2018


fhahn updated this revision to Diff 148897.
fhahn added a comment.

The parameter for patchReplacement is certainly not needed, I removed it. For most other uses, there is no dominance for combineMetadata, as it is used for code sinking and hoisting with instructions form different code paths. I've created https://reviews.llvm.org/D47475 to handle all calls to combineMetadata explicitly.


https://reviews.llvm.org/D47339

Files:
  include/llvm/Analysis/Utils/Local.h
  lib/Transforms/Utils/Local.cpp
  test/Transforms/NewGVN/metadata-nonnull.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47339.148897.patch
Type: text/x-patch
Size: 7686 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180529/cfb513ea/attachment.bin>


More information about the llvm-commits mailing list