[PATCH] D47475: [Local] Make KDominatesJ required for combineMetadata.

[Florian Hahn via Phabricator via llvm-commits]

fhahn created this revision.
fhahn added reviewers: dberlin, nlopes.

This patch makes the KDominatesJ argument non-optional, to force people
to think about it. Most cases where it is false are either code hoisting
or code sinking, where we pick one instruction from a set of
equal instructions among different code paths.

I think patch should have some tests, I will add some in a bit.


https://reviews.llvm.org/D47475

Files:
  include/llvm/Analysis/Utils/Local.h
  lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
  lib/Transforms/InstCombine/InstCombinePHI.cpp
  lib/Transforms/Scalar/GVNHoist.cpp
  lib/Transforms/Scalar/GVNSink.cpp
  lib/Transforms/Scalar/JumpThreading.cpp
  lib/Transforms/Scalar/MemCpyOptimizer.cpp
  lib/Transforms/Utils/Local.cpp
  lib/Transforms/Utils/SimplifyCFG.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47475.148896.patch
Type: text/x-patch
Size: 6498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180529/11369d07/attachment.bin>