[PATCH] D47414: [llvm-objcopy] Fix null symbol handling
    James Henderson via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue May 29 03:36:52 PDT 2018
    
    
  
jhenderson added a comment.
In https://reviews.llvm.org/D47414#1114472, @alexshap wrote:
> in general i agree with @jhenderson. Regarding changing the definition of empty() or checking the size() (what i suggested) - the latter seemes to be more explicit to me and more intuitive / causing less surprise, but i don't insist.
My main concern is that a developer can easily forget the difference, and use the wrong one, but I'm not particularly fussed either way.
Repository:
  rL LLVM
https://reviews.llvm.org/D47414
    
    
More information about the llvm-commits
mailing list