[PATCH] D47424: [MIRParser] Add parser support for 'true' and 'false' i1s.

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg added inline comments.


================
Comment at: lib/CodeGen/MIRParser/MIParser.cpp:1389
+  case MIToken::IntegerLiteral:
+    if (parseIRConstant(Loc, C))
+      return true;
----------------
It looks like `parseIRConstant` already handles `true` and `false`. Can we reuse that here?


================
Comment at: lib/CodeGen/MIRParser/MIParser.cpp:1907
+    else
+      return error("invalid integer predicate");
+  } else if (Token.is(MIToken::kw_false)) {
----------------
Can we get a test for the errors here?


Repository:
  rL LLVM

https://reviews.llvm.org/D47424