[PATCH] D44528: [PowerPC] Implement canCombineStoreAndExtract and provide the missing pattern for the combination

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added a comment.

Ping.



================
Comment at: test/CodeGen/PowerPC/combine-extract-store.ll:8
+; Function Attrs: norecurse nounwind
+define void @test(<4 x i32>* noalias nocapture readonly %VP, <4 x i32>* noalias nocapture %VP2, i32* noalias nocapture %IP) local_unnamed_addr #0 {
+; CHECK-LABEL: test:
----------------
lei wrote:
> nit: line past col 80
> 
I think we generally allow code in test cases to have lines however long clang produces them.


================
Comment at: test/CodeGen/PowerPC/combine-extract-store.ll:11
+; CHECK:       # %bb.0: # %entry
+; CHECK-NEXT:    vspltisw 2, 4
+; CHECK-NEXT:    lvx 3, 0, 3
----------------
lei wrote:
> Should these 2 lines be CHECK-DAG since they don't necessarily have to happen in this order?
> 
They certainly don't need to happen in this order, but I find that changing the CHECK directive produced by the tool makes the test case harder to maintain sometimes.


Repository:
  rL LLVM

https://reviews.llvm.org/D44528