[PATCH] D47437: [PowerPC] Fix the incorrect iterator inside peephole

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 28 19:23:39 PDT 2018


steven.zhang added a comment.

Hi, Nemanjai, if change it to the rangefor, we will walk the DAG in the reverse order(begin() -> end()), which result in two case failed. CodeGen/PowerPC/cmpb.ll and CodeGen/PowerPC/cmpb-ppc32.ll. It seems that, our implementation has some dependent on how we walk the DAG.


https://reviews.llvm.org/D47437





More information about the llvm-commits mailing list