[PATCH] D47443: [X86] Lowering FMA intrinsics to native IR (LLVM part)

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In https://reviews.llvm.org/D47443#1114199, @tkrupa wrote:

> In https://reviews.llvm.org/D47443#1114187, @RKSimon wrote:
>
> > You're going to hate me for this, but we could do with -fast-isel test files covering the builtin test files codegen on the clang side
>
>
> Not really, thankfully these are all auto-generated from clang tests. So do you mean we could do with fast-isel tests instead of these or in addition to these?


We need both please - the fast-isel tests are there to ensure non-optimized builds do not deviate too much from what coders were trying to accomplish with intrinsics - which is quite different in purpose to the regular dag tests which concern optimization combines.


Repository:
  rL LLVM

https://reviews.llvm.org/D47443