[llvm] r333378 - [LLVM-C] [OCaml] Remove LLVMAddBBVectorizePass

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Mon May 28 09:58:10 PDT 2018


Author: maskray
Date: Mon May 28 09:58:10 2018
New Revision: 333378

URL: http://llvm.org/viewvc/llvm-project?rev=333378&view=rev
Log:
[LLVM-C] [OCaml] Remove LLVMAddBBVectorizePass

Summary: It was fully replaced back in 2014, and the implementation was removed 11 months ago by r306797.

Reviewers: hfinkel, chandlerc, whitequark, deadalnix

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D47436

Modified:
    llvm/trunk/bindings/ocaml/transforms/vectorize/llvm_vectorize.ml
    llvm/trunk/bindings/ocaml/transforms/vectorize/llvm_vectorize.mli
    llvm/trunk/bindings/ocaml/transforms/vectorize/vectorize_ocaml.c
    llvm/trunk/docs/ReleaseNotes.rst
    llvm/trunk/include/llvm-c/Transforms/Vectorize.h
    llvm/trunk/lib/Transforms/Vectorize/Vectorize.cpp
    llvm/trunk/test/Bindings/OCaml/vectorize.ml

Modified: llvm/trunk/bindings/ocaml/transforms/vectorize/llvm_vectorize.ml
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/bindings/ocaml/transforms/vectorize/llvm_vectorize.ml?rev=333378&r1=333377&r2=333378&view=diff
==============================================================================
--- llvm/trunk/bindings/ocaml/transforms/vectorize/llvm_vectorize.ml (original)
+++ llvm/trunk/bindings/ocaml/transforms/vectorize/llvm_vectorize.ml Mon May 28 09:58:10 2018
@@ -7,9 +7,6 @@
  *
  *===----------------------------------------------------------------------===*)
 
-external add_bb_vectorize
-  : [<Llvm.PassManager.any] Llvm.PassManager.t -> unit
-  = "llvm_add_bb_vectorize"
 external add_loop_vectorize
   : [<Llvm.PassManager.any] Llvm.PassManager.t -> unit
   = "llvm_add_loop_vectorize"

Modified: llvm/trunk/bindings/ocaml/transforms/vectorize/llvm_vectorize.mli
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/bindings/ocaml/transforms/vectorize/llvm_vectorize.mli?rev=333378&r1=333377&r2=333378&view=diff
==============================================================================
--- llvm/trunk/bindings/ocaml/transforms/vectorize/llvm_vectorize.mli (original)
+++ llvm/trunk/bindings/ocaml/transforms/vectorize/llvm_vectorize.mli Mon May 28 09:58:10 2018
@@ -12,11 +12,6 @@
     This interface provides an OCaml API for LLVM vectorize transforms, the
     classes in the [LLVMVectorize] library. *)
 
-(** See the [llvm::createBBVectorizePass] function. *)
-external add_bb_vectorize
-  : [<Llvm.PassManager.any] Llvm.PassManager.t -> unit
-  = "llvm_add_bb_vectorize"
-
 (** See the [llvm::createLoopVectorizePass] function. *)
 external add_loop_vectorize
   : [<Llvm.PassManager.any] Llvm.PassManager.t -> unit

Modified: llvm/trunk/bindings/ocaml/transforms/vectorize/vectorize_ocaml.c
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/bindings/ocaml/transforms/vectorize/vectorize_ocaml.c?rev=333378&r1=333377&r2=333378&view=diff
==============================================================================
--- llvm/trunk/bindings/ocaml/transforms/vectorize/vectorize_ocaml.c (original)
+++ llvm/trunk/bindings/ocaml/transforms/vectorize/vectorize_ocaml.c Mon May 28 09:58:10 2018
@@ -20,12 +20,6 @@
 #include "caml/misc.h"
 
 /* [<Llvm.PassManager.any] Llvm.PassManager.t -> unit */
-CAMLprim value llvm_add_bb_vectorize(LLVMPassManagerRef PM) {
-  LLVMAddBBVectorizePass(PM);
-  return Val_unit;
-}
-
-/* [<Llvm.PassManager.any] Llvm.PassManager.t -> unit */
 CAMLprim value llvm_add_loop_vectorize(LLVMPassManagerRef PM) {
   LLVMAddLoopVectorizePass(PM);
   return Val_unit;

Modified: llvm/trunk/docs/ReleaseNotes.rst
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/ReleaseNotes.rst?rev=333378&r1=333377&r2=333378&view=diff
==============================================================================
--- llvm/trunk/docs/ReleaseNotes.rst (original)
+++ llvm/trunk/docs/ReleaseNotes.rst Mon May 28 09:58:10 2018
@@ -146,13 +146,15 @@ Changes to the AVR Target
 Changes to the OCaml bindings
 -----------------------------
 
- During this release ...
+* Remove ``add_bb_vectorize``.
 
 
 Changes to the C API
 --------------------
 
- During this release ...
+* Remove ``LLVMAddBBVectorizePass``. The implementation was removed and the C
+  interface was made a deprecated no-op in LLVM 5. Use
+  ``LLVMAddSLPVectorizePass`` instead to get the supported SLP vectorizer.
 
 
 External Open Source Projects Using LLVM 7

Modified: llvm/trunk/include/llvm-c/Transforms/Vectorize.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm-c/Transforms/Vectorize.h?rev=333378&r1=333377&r2=333378&view=diff
==============================================================================
--- llvm/trunk/include/llvm-c/Transforms/Vectorize.h (original)
+++ llvm/trunk/include/llvm-c/Transforms/Vectorize.h Mon May 28 09:58:10 2018
@@ -33,9 +33,6 @@ extern "C" {
  * @{
  */
 
-/** DEPRECATED - Use LLVMAddSLPVectorizePass */
-void LLVMAddBBVectorizePass(LLVMPassManagerRef PM);
-
 /** See llvm::createLoopVectorizePass function. */
 void LLVMAddLoopVectorizePass(LLVMPassManagerRef PM);
 

Modified: llvm/trunk/lib/Transforms/Vectorize/Vectorize.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/Vectorize.cpp?rev=333378&r1=333377&r2=333378&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Vectorize/Vectorize.cpp (original)
+++ llvm/trunk/lib/Transforms/Vectorize/Vectorize.cpp Mon May 28 09:58:10 2018
@@ -34,10 +34,6 @@ void LLVMInitializeVectorization(LLVMPas
   initializeVectorization(*unwrap(R));
 }
 
-// DEPRECATED: Remove after the LLVM 5 release.
-void LLVMAddBBVectorizePass(LLVMPassManagerRef PM) {
-}
-
 void LLVMAddLoopVectorizePass(LLVMPassManagerRef PM) {
   unwrap(PM)->add(createLoopVectorizePass());
 }

Modified: llvm/trunk/test/Bindings/OCaml/vectorize.ml
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Bindings/OCaml/vectorize.ml?rev=333378&r1=333377&r2=333378&view=diff
==============================================================================
--- llvm/trunk/test/Bindings/OCaml/vectorize.ml (original)
+++ llvm/trunk/test/Bindings/OCaml/vectorize.ml Mon May 28 09:58:10 2018
@@ -42,7 +42,6 @@ let test_transforms () =
   ignore (build_ret_void (builder_at_end context (entry_block fn)));
 
   ignore (PassManager.create ()
-           ++ add_bb_vectorize
            ++ add_loop_vectorize
            ++ add_slp_vectorize
            ++ PassManager.run_module m




More information about the llvm-commits mailing list