[PATCH] D47408: [PM/LoopUnswitch] When using the new SimpleLoopUnswitch pass, schedule loop-cleanup passes at the beginning of the loop pass pipeline, and re-enqueue loops after even trivial unswitching.

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

Looks ok to me.



================
Comment at: llvm/lib/Passes/PassBuilder.cpp:396-397
   // `SimplifyCFGPass` and `InstCombinePass` are used. We have
   // `LoopSimplifyCFGPass` which isn't yet powerful enough, and the closest to
   // the other we have is `LoopInstSimplify`.
   LoopPassManager LPM1(DebugLogging), LPM2(DebugLogging);
----------------
Time to update the comment? :)


================
Comment at: llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp:1937-1938
 
     // If the current loop remains valid, we should revisit it to catch any
     // other unswitch opportunities. Otherwise, we need to mark it as deleted.
     if (CurrentLoopValid)
----------------
mention that current loop gets cleaned up as well (if cleanup scheduled)?


Repository:
  rL LLVM

https://reviews.llvm.org/D47408