[PATCH] D46992: [AMDGPU] Add perf hints to functions

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 25 09:56:07 PDT 2018


rampitec marked an inline comment as done.
rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:178
+
+  if (auto Resolver = MF.getMMI().getResolver()) {
+    if (AMDGPUPerfHintAnalysis *PHA = static_cast<AMDGPUPerfHintAnalysis*>(
----------------
vpykhtin wrote:
> I would use "auto &Resolver" to emphasize Resolver is a reference not a temp object
Resolver is a pointer, not an object or reference.


https://reviews.llvm.org/D46992





More information about the llvm-commits mailing list