[PATCH] D47438: [ScopInfo] Update Scop::addUserContext() to C++ interface

[Tobias Grosser via Phabricator via llvm-commits]

grosser requested changes to this revision.
grosser added a comment.
This revision now requires changes to proceed.

Very nice!



================
Comment at: lib/Analysis/ScopInfo.cpp:2116
+  isl::set UserContext = isl::set(getIslCtx(), UserContextStr.c_str());
+  isl::space Space = isl::manage(getParamSpace().release());
+  if (Space.dim(isl::dim::param) != UserContext.dim(isl::dim::param)) {
----------------
Drop the manage(release()) pattern. This is not needed. Just say `getParamSpace()`.


================
Comment at: lib/Analysis/ScopInfo.cpp:2131
     if (NameContext != NameUserContext) {
-      auto SpaceStr = isl_space_to_str(Space);
+      auto SpaceStr = Space.to_str();
       errs() << "Error: the name of dimension " << i
----------------
LLVM coding conventions prefers explicit types. As you already change this line and this is a mechanical change, I suggest to update this as well (please update commit message / summary to mention this).


Repository:
  rPLO Polly

https://reviews.llvm.org/D47438