[PATCH] D46912: StructurizeCFG: Adjust the loop depth for a subregion to order the nodes correctly

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Sun May 27 10:09:16 PDT 2018


On Wed, May 16, 2018 at 1:32 PM, Changpeng Fang via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> cfang marked 2 inline comments as done.
> cfang added a comment.
>
> Right. Reverse Post Order (RPO) should be the fundamental order. But
> apparently there are some cases that pure RPO does not work.
>

These should be analyzed, because something is fundamentally wrong there :)
(I understand being pragmatic and fixing bugs, but on the side we should
look deeper and understand what is going wrong)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180527/d0d09fa7/attachment.html>


More information about the llvm-commits mailing list