[PATCH] D47391: [COFF] Don't crash when emitting symbol table for SafeSEH input files
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 25 13:47:07 PDT 2018
smeenai added inline comments.
================
Comment at: COFF/Writer.cpp:614
if (auto *D = dyn_cast<DefinedRegular>(Def))
- if (D->getChunk()->isCodeView())
+ if (D->getChunk()->isCodeView() || D->getChunk()->isSXData())
return None;
----------------
Does this need to be generalized to all RVA table sections, e.g. the control flow guard sections? We aren't using that right now, so it's not an immediate concern, but just wondering in general.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D47391
More information about the llvm-commits
mailing list