[PATCH] D45098: [AArch64] fix PR32384: bump the number of stores per memset/memcpy
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 25 11:44:14 PDT 2018
efriedma added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/arm64-memset-to-bzero.ll:4
+; RUN: llc %s -mtriple=arm64-linux-gnu -mattr=+strict-align -o - | \
+; RUN: FileCheck --check-prefixes=CHECK,CHECK-LINUX %s
; <rdar://problem/14199482> ARM64: Calls to bzero() replaced with calls to memset()
----------------
evandro wrote:
> efriedma wrote:
> > This change doesn't make any sense to me; what are you trying to do?
> This test doesn't seem to expect that any string function is inlined, so I added `-mattr=+strict-align` to prevent this.
Those two aren't related...? I mean, yes, it has the right effect, but that's just a coincidence. Please mark the functions optsize instead.
https://reviews.llvm.org/D45098
More information about the llvm-commits
mailing list