[PATCH] D43962: [GlobalISel][utils] Adding the init version of Instruction Select Testgen

[Roman Tereshin via Phabricator via llvm-commits]

rtereshin added a comment.

ping



================
Comment at: lib/CodeGen/GlobalISel/InstructionSelectorTestgen.cpp:260
+      Keys.push_back(Item.first);
+    std::sort(Keys.begin(), Keys.end(), std::greater<decltype(Keys.front())>());
+    BitVector VisitedPhysRegs;
----------------
mgrang wrote:
> Please use llvm::sort instead of std::sort. See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements.
Good catch, thanks, will do!


Repository:
  rL LLVM

https://reviews.llvm.org/D43962