[PATCH] D46265: StackColoring: better handling of statically unreachable code

Than McIntosh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 25 06:39:08 PDT 2018


thanm added a comment.

> I agree, given the nature of the change. I'll prepare another patch.

OK, I finally figured out the problem. It turns out that "isel" is not (as I had naively assumed) the instruction selection pass, it's a separate pass specific to AMDGPU (confusing name, IMHO).  I changed the test to use "-start-before dwarfehprepare" (a real pass that is not target-specific) and it seems to work now. I will send another patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D46265





More information about the llvm-commits mailing list