[PATCH] D46830: [llvm-objcopy] Add --keep-file-symbols option

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

LGTM, with the suggested test change. The bug needs fixing separately.



================
Comment at: test/tools/llvm-objcopy/keep-file-symbols.test:28-35
+  Weak:
+    - Name:     baz
+      Type:     STT_FUNC
+      Section:  .text
+  Global:
+    - Name:     foobar
+      Type:     STT_FUNC
----------------
You only need two symbols - one file symbol and one non-file symbol.


================
Comment at: test/tools/llvm-objcopy/keep-file-symbols.test:37-48
+#STRIPALL: Symbols [
+#STRIPALL-NEXT:  Symbol {
+#STRIPALL-NEXT:    Name: foo
+#STRIPALL-NEXT:    Value: 0x0
+#STRIPALL-NEXT:    Size: 0
+#STRIPALL-NEXT:    Binding: Local
+#STRIPALL-NEXT:    Type: File
----------------
Wait, shouldn't there be a null symbol here? Null symbols are required... That's probably a bug unrelated to your change, but should be fixed ASAP.


Repository:
  rL LLVM

https://reviews.llvm.org/D46830