[PATCH] D47370: AMDGPU: Round up kernel argument allocation size

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 25 05:50:31 PDT 2018


arsenm created this revision.
arsenm added reviewers: t-tye, rampitec, kzhuravl, b-sumner.
Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng.

AFAIK the driver's allocation will actually have to round this
up anyway. It is useful to track the rounded up size, so that
the end of the kernel segment is known to be dereferencable so
a wider s_load_dword can be used for a short argument at the end
of the segment.

One thing I'm unclear on is if we need to really allocate the
implicit arg bytes if they aren't actually used


https://reviews.llvm.org/D47370

Files:
  lib/Target/AMDGPU/AMDGPUMachineFunction.h
  lib/Target/AMDGPU/AMDGPUSubtarget.cpp
  lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
  test/CodeGen/AMDGPU/kernel-args.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.kernarg.segment.ptr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47370.148590.patch
Type: text/x-patch
Size: 13637 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180525/dbc53fcd/attachment.bin>


More information about the llvm-commits mailing list