[PATCH] D47098: [ELF] Make R_GOTONLY_PC_FROM_END R_GOTREL_FROM_END relative to _GLOBAL_OFFSET_TABLE_ instead of end of .got

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

I suggest separating R_X86_64_GOTOFF64 change from this patch to different one. I think it is completely independent.

Also, you are creating "relocation" folder for the new test. Please do not do it, just place the test near our others tests we have for the relocations.
(If you think it is worth to add a new folder for relocations it should be in a separate review and/or discussed first. I probably would not do that, btw).



================
Comment at: test/ELF/relocation-i686.s:3
 // RUN: llvm-mc -filetype=obj -triple=i686-unknown-linux %p/Inputs/shared.s -o %t2.o
-// RUN: ld.lld -shared %t2.o -o %t2.so
+// RUN: ld.lld -shared %t2.o -soname t2.so -o %t2.so
 // RUN: ld.lld --hash-style=sysv %t %t2.so -o %t2
----------------
Why you had to do that?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47098