jhenderson added a comment. Code change looks fine, but could you add a test to show that --keep-file-symbols trumps --strip-symbol, assuming that is the desired behaviour (double-check against GNU, I suggest here). Repository: rL LLVM https://reviews.llvm.org/D46830