[PATCH] D46699: [ThinLTO] Print module summary index to assembly

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

> Although the support in this patch to skip the summary assembly will not handle this, as it only skips a line at a time and won't understand the subsequent lines which don't start with the summary ID.

You could always count parens and stop when you reach 0. That's probably what the end state for skipping should look like as well.

For printing, if you think that would work better for you I can probably tolerate the single line.



================
Comment at: lib/IR/AsmWriter.cpp:2776
+static std::string getLinkagePrintName(GlobalValue::LinkageTypes LT,
+                                       bool AddSpace = true) {
+  std::string Space = AddSpace ? " " : "";
----------------
tejohnson wrote:
> pcc wrote:
> > Maybe changing the other callers to do:
> > ```if (GV->getLinkage() != GlobalValue::ExternalLinkage)
> >    Out << getLinkagePrintName(GV->getLinkage()) << ' ';
> > ```
> > would be clearer than adding the argument?
> I thought about that but felt it was less churn and clearer to handle it in one centralized place. If you much prefer changing the callers, I can do that instead.
Can you do that please? I do prefer to avoid mysterious bool arguments wherever possible.


Repository:
  rL LLVM

https://reviews.llvm.org/D46699