[PATCH] D47343: [MCJIT] Call JIT notifiers only after code sections are ready.

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 24 14:49:09 PDT 2018


lhames added a comment.

This patch doesn't affect any of my use-cases, but it's possible that some clients are relying on the fact that memory will still be writable at this point.

As an alternative: ORC's RTDyldObjectLinkingLayer has a NotifyFinalized callback that is called in the equivalent location (i.e. after finalizeMemory has been called). If we want to maintain behavior for existing MCJIT clients it seems reasonable to add a matching "NotifyFinalized" callback to MCJIT.


Repository:
  rL LLVM

https://reviews.llvm.org/D47343





More information about the llvm-commits mailing list