[PATCH] D46896: [llvm-objcopy] Add --strip-unneeded option

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 24 14:15:24 PDT 2018


alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/Object.cpp:261
+  return const_cast<Symbol *>(
+      static_cast<const SymbolTableSection *>(this)->getSymbolByIndex(Index));
+}
----------------
paulsemel wrote:
> alexshap wrote:
> > probably you don't need the "internal" cast static_cast<const SymbolTableSection *>(this), do you ? 
> I'm sorry, but I don't see how I can do this differently. A bit of help would be appreciated.
> If I do not `static_cast` this, I will self call, no ?
oh, right, it's fine


Repository:
  rL LLVM

https://reviews.llvm.org/D46896





More information about the llvm-commits mailing list