[PATCH] D46896: [llvm-objcopy] Add --strip-unneeded option

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 24 12:34:32 PDT 2018


jakehehrlich added a comment.

As always the right solution winds up 10000 times simpler than anything I considered in the interim. This looks good to me after fixing Alex's and my comments.



================
Comment at: tools/llvm-objcopy/Object.cpp:950
 
+void Object::markSymbols() {
+  for (const SecPtr &Sec : Sections)
----------------
This can be done externally via a loop over `sections()`. I'd like to keep the exposed methods as simple as possible.


Repository:
  rL LLVM

https://reviews.llvm.org/D46896





More information about the llvm-commits mailing list