[PATCH] D47329: [llvm-exegesis] Analysis: Display idealized sched class port pressure.

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added inline comments.


================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:175
   // cluster.
   std::sort(PointIds.begin(), PointIds.end(),
             [this](const size_t A, const size_t B) {
----------------
Please use llvm::sort instead of std::sort. See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements.


================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:468
+  llvm::SmallVector<float, 32> DensePressure(SM.getNumProcResourceKinds());
+  std::sort(WPRS.begin(), WPRS.end(),
+            [](const llvm::MCWriteProcResEntry &A,
----------------
Please use llvm::sort instead of std::sort. See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements.


================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:491
+                                                   ProcResDesc->NumUnits);
+      std::sort(Subunits.begin(), Subunits.end(),
+                [&DensePressure](const uint16_t A, const uint16_t B) {
----------------
Same here.


Repository:
  rL LLVM

https://reviews.llvm.org/D47329