[PATCH] D47318: [llvm-exegesis] Analysis: Show value extents.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet accepted this revision.
gchatelet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:203
          ++I) {
+      const auto &Point = Points[PointIds[I]];
       OS << "<li><span class=\"mono\">";
----------------
Move this outside the loop then you can shorten `MeasurementStats` declaration.


================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:210
+      for (size_t J = 0, F = Point.Measurements.size(); J < F; ++J) {
+        MeasurementStats[J].accumulate(Point.Measurements[J]);
+      }
----------------
As discussed let's use something like `insert` or `push` instead of `accumulate`.


Repository:
  rL LLVM

https://reviews.llvm.org/D47318