[PATCH] D45330: [IPSCCP] Use PredicateInfo to propagate facts from cmp instructions.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: test/Other/opt-O2-pipeline.ll:280
 ; CHECK-NEXT: Pass Arguments:
+; CHECK-NEXT:  FunctionPass Manager
+; CHECK-NEXT:     Dominator Tree Construction
----------------
efriedma wrote:
> fhahn wrote:
> > Arg, the order, in which the additional function pass managers for the analysis required by IPSCCP and GlobalOpt are added, is not deterministic.
> > 
> > A quick look at the legacy pass manager suggests that it uses a bunch of maps and sets to register discovered new passes. So those legacy pass manager tests sometimes fail on some systems....  I am not sure how to best sort out that out. Any ideas?
> This is specifically the AvailableAnalysis map?  You can switch to http://llvm.org/docs/ProgrammersManual.html#llvm-adt-mapvector-h, I guess...
Thank you very much, it's enough to use MapVector for OnTheFlyManagers : D47317


https://reviews.llvm.org/D45330