[PATCH] D46874: [MC] - Add .stack_size sections into groups and link them with .text

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, but as mentioned earlier, you should probably get a second opinion.



================
Comment at: test/CodeGen/X86/stack-size-section-function-sections.ll:11
+
+; Check we add .stack_size section to COMDAT with the corresponding .text section if such COMDAT exists. 
+
----------------
Nit: "to COMDAT" -> "to a COMDAT group" and "if such COMDAT exists" -> "if such a COMDAT exists".


================
Comment at: test/CodeGen/X86/stack-size-section.ll:33
+
+; Check that we assign an unique ID to .stack_sizes if it is linked with an unique .text section.
+; CHECK: .section .text.func3,"ax", at progbits
----------------
Nit: "an unique" -> "a unique" x 2.

English is weird!


https://reviews.llvm.org/D46874