[PATCH] D47263: [dwarfdump] Have -c and -p work together

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 24 02:57:40 PDT 2018


JDevlieghere added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:479
+    DIDumpOptions NewDumpOpts = DumpOpts;
+    NewDumpOpts.ShowParents = false;
+    NewDumpOpts.ShowChildren = false;
----------------
aprantl wrote:
> This looks unintuitive: Does dumpParentChain print all parents?
It does indeed. There's a comment expressing this above the function, which is why it's not repeated here. 


https://reviews.llvm.org/D47263





More information about the llvm-commits mailing list