[PATCH] D47254: [llvm-exegesis] Show sched class details in analysis.
Guillaume Chatelet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 24 02:47:45 PDT 2018
gchatelet accepted this revision.
gchatelet added inline comments.
This revision is now accepted and ready to land.
================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:227
+// a P016 (ProcResIdx=10), then the cycles consumed by P0 are also consumed
+// by P06 and P016, and the resources consumed by P06 are also consumed by
+// P016. In the figure below, parenthesized cycles denote implied usage of
----------------
nit: Add `(ProcResIdx = 7)` and `(ProcResIdx = 10)` after `P06` and `P016`.
================
Comment at: tools/llvm-exegesis/lib/Analysis.cpp:230
+// superresources by subresources:
+// P0 P06 P016
+// uOp1 1 (1) (1)
----------------
Uber nit: can you reduce the 3rd column by one character?
Repository:
rL LLVM
https://reviews.llvm.org/D47254
More information about the llvm-commits
mailing list