[PATCH] D46630: [RISCV] Insert NOPs and R_RISCV_ALIGN relocation type for .align directive when linker relaxation enabled

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 24 00:58:26 PDT 2018


asb added a comment.

I think that customising the handling of MCAlignFragment is going to be the more correct (with regards to the LLVM MC design and layering) and maintainable way.

I haven't fully stepped through the ordering of function calls when producing an object. Is your concern that the current call to writeNopData  from writeFragment comes too late to create the relocation?


Repository:
  rL LLVM

https://reviews.llvm.org/D46630





More information about the llvm-commits mailing list