[PATCH] D47308: [ORC] Perform name mangling in findSymbolIn(), as done in findSymbol().

[Andres Freund via Phabricator via llvm-commits]

anarazel added a comment.

> FWIW, I don't think this is really obvious / trivial enough to land w/o review by someone familiar w/ Orc and the users.



> While I *suspect* the lack of mangling is jsut an oversight, it is a behavior change and might break users or should at least be thought about by someone w/ familiarity.

I don't think it's actually an *exposed* behaviour change. The modified file is in lib/ and therefore not externally exposed, and before https://reviews.llvm.org/D44889 OrcCBindingsStack::findSymbolIn() wasn't actually called from anywhere (OrcCBindingsStack.h is only included by OrcCBindings.cpp). Therefore the code previously was dead code, which explains why nobody noticed the issue previously.

> Until this is fixed one way or another, you should probably revert the patch that is failing bots.

Seems sensible. Will do in a few, just need to get back to the laptop with the credentials.


Repository:
  rL LLVM

https://reviews.llvm.org/D47308